-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration tests fix #1171
Integration tests fix #1171
Changes from 3 commits
f400a98
d0760c4
609138a
cd0d9bb
91cdc57
5d4b857
8678094
c47a411
8b72bb5
93261af
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,7 @@ | |
import pytest | ||
|
||
from fedot.api.main import Fedot | ||
from fedot.core.pipelines.pipeline import Pipeline, PipelineNode | ||
from fedot.core.repository.tasks import TsForecastingParams | ||
from fedot.core.utils import fedot_project_root | ||
from fedot.remote.infrastructure.clients.test_client import TestClient | ||
|
@@ -94,13 +95,15 @@ def test_pseudo_remote_composer_ts_forecasting(): | |
'show_progress': False | ||
} | ||
|
||
preset = 'best_quality' | ||
automl = Fedot(problem='ts_forecasting', timeout=0.2, task_params=TsForecastingParams(forecast_length=1), | ||
preset=preset, **composer_params) | ||
automl = Fedot(problem='ts_forecasting', task_params=TsForecastingParams(forecast_length=1), | ||
**composer_params) | ||
|
||
path = os.path.join(fedot_project_root(), 'test', 'data', 'short_time_series.csv') | ||
|
||
automl.fit(path, target='sea_height') | ||
predefined_model = Pipeline(PipelineNode('ridge', nodes_from=[PipelineNode('lagged')])) | ||
|
||
automl.fit(path, target='sea_height', predefined_model=predefined_model) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Эти строки не нарушают контракт юнит-теста? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Нарушают смысл, потому что тут идея в том чтобы протестировать оптимизацию структуры пайплайна с использованием mock-а для удаленной вычислительной среды. А с predefined_model оптимизатор вообще не стартует. А падал именно этот тест? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Да, модель не всегда вычисляется, зачастую при обучении выдаётся ошибка "No models were found". Но когда срабатывает, то будет пайплайн со скриншота. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hm. Ну давай пока просто отключим этот тест, функциональность не критичная. Пометь плз как issue. |
||
predict = automl.predict(path) | ||
shutil.rmtree(os.path.join(fedot_project_root(), 'test', 'data', 'remote', 'fitted_pipeline')) # recursive deleting | ||
shutil.rmtree(os.path.join(fedot_project_root(), 'test', 'data', 'remote', 'fitted_pipeline'), # recursive deleting | ||
valer1435 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
ignore_errors=True) | ||
assert predict is not None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Почему прищлось ограничить выбор моделей? Так по идее ничего не скомпозируется
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Сделал так, потому что без этого выбираться модели, которые не обучаются на данных теста. Например, "sparse_lagged" выбиралась и вызывала ошибку, но не только.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Стоит добавить сюда табличных моделек (хотя бы rf и knn)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Регрессионные версии, разумеется
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Вообще убрал эти правки, кажется, в новой версии master, это уже исправно работает.