Add tuning history to OptHistory #1188
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1188 +/- ##
==========================================
+ Coverage 79.50% 79.53% +0.03%
==========================================
Files 145 145
Lines 10021 10023 +2
==========================================
+ Hits 7967 7972 +5
+ Misses 2054 2051 -3
|
kasyanovse
requested changes
Oct 26, 2023
| @@ -33,6 +33,7 @@ def __init__(self, task: Task): | |||
| self.eval_time_constraint = None | |||
| self.additional_params = {} | |||
| self.adapter = PipelineAdapter() | |||
| self.history = None | |||
There was a problem hiding this comment.
Вроде бы новых тестов для history нет, значит во всех тестах он по умолчанию принимается равным None?
В таком случае стоит добавить хотя бы один тест, где он не будет равен None.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1187 (follows aimclub/GOLEM#228).
Changes usages of
history.individualstohistory.generations, since the old field name is deprecated in GOLEM.