Remove callback #256
Merged
Remove callback #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #256 +/- ##
=======================================
Coverage 71.92% 71.92%
=======================================
Files 136 136
Lines 8145 8145
=======================================
Hits 5858 5858
Misses 2287 2287 ☔ View full report in Codecov by Sentry. |
nicl-nno
reviewed
Dec 22, 2023
| @@ -60,7 +60,7 @@ def _tune(self, graph: DomainGraphForTune, show_progress: bool = True) -> \ | |||
| n_trials=self.iterations, | |||
| n_jobs=self.n_jobs, | |||
| timeout=remaining_time, | |||
| callbacks=[self.early_stopping_callback], | |||
| callbacks=[self.early_stopping_callback] if not is_multi_objective else None, | |||
There was a problem hiding this comment.
Может какой-то варнинг печатать, чтобы пользователь был в курсе?
nicl-nno
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor fix for
OptunaTuner:early_stopping_iterationis not applicable for multi-objective problem.