Skip to content

Use constant-time compare in BasicAuth #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Cycloctane wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use constant-time compare in BasicAuth #531

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion aiohttp_remotes/basic_auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import base64
import binascii
from secrets import compare_digest
from typing import Awaitable, Callable, Iterable

from typing_extensions import NoReturn
Expand Down Expand Up @@ -58,7 +59,9 @@ async def middleware(

username, password = credentials

if username != self._username or password != self._password:
if username != self._username or not compare_digest(
password, self._password
):
return await self.raise_error(request)

return await handler(request)
Loading