Skip to content

Conversation

Cycloctane
Copy link
Member

What do these changes do?

update-pre-commit is broken after #5261 due to the incorrect github.repository_owner condition. (See https://github.com/aio-libs/aiohttp/actions/workflows/update-pre-commit.yml). pre-commit auto update prs are actually created by pre-commit-ci app. This workflow is not needed anyway.

@Cycloctane Cycloctane requested a review from webknjaz as a code owner October 19, 2025 23:05
@Cycloctane Cycloctane requested a review from asvetlov as a code owner October 19, 2025 23:09
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 19, 2025
Copy link

codecov bot commented Oct 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.74%. Comparing base (e260b15) to head (54973a7).
⚠️ Report is 74 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #11689    +/-   ##
========================================
  Coverage   98.74%   98.74%            
========================================
  Files         127      127            
  Lines       43448    43549   +101     
  Branches     2326     2327     +1     
========================================
+ Hits        42903    43003   +100     
- Misses        389      390     +1     
  Partials      156      156            
Flag Coverage Δ
CI-GHA 98.63% <ø> (+<0.01%) ⬆️
OS-Linux 98.36% <ø> (+<0.01%) ⬆️
OS-Windows 96.69% <ø> (-0.01%) ⬇️
OS-macOS 97.58% <ø> (+<0.01%) ⬆️
Py-3.10.11 97.15% <ø> (+<0.01%) ⬆️
Py-3.10.18 ?
Py-3.10.19 97.65% <ø> (?)
Py-3.11.13 ?
Py-3.11.14 97.84% <ø> (?)
Py-3.11.9 97.35% <ø> (+<0.01%) ⬆️
Py-3.12.10 97.45% <ø> (+<0.01%) ⬆️
Py-3.12.11 ?
Py-3.12.12 97.95% <ø> (?)
Py-3.13.7 ?
Py-3.13.8 98.20% <ø> (?)
Py-3.14.0 98.15% <ø> (-0.01%) ⬇️
Py-3.14.0t 97.22% <ø> (+<0.01%) ⬆️
Py-pypy3.10.16-7.3.19 90.63% <ø> (-5.75%) ⬇️
VM-macos 97.58% <ø> (+<0.01%) ⬆️
VM-ubuntu 98.36% <ø> (+<0.01%) ⬆️
VM-windows 96.69% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Oct 19, 2025

CodSpeed Performance Report

Merging #11689 will not alter performance

Comparing Cycloctane:remove-unused-ci (54973a7) with master (42fc48a)

Summary

✅ 59 untouched

@@ -0,0 +1 @@
Remove unused ``update-pre-commit`` github action -- by :user:`Cycloctane`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid using imperative mood. Change log is neither a Git log, nor a TODO-list. Describe what changed, not a future plan.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, this is removing a workflow, not an action.

@Cycloctane Cycloctane requested a review from webknjaz October 20, 2025 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants