-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Remove unused update-pre-commit ci workflow #11689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #11689 +/- ##
========================================
Coverage 98.74% 98.74%
========================================
Files 127 127
Lines 43448 43549 +101
Branches 2326 2327 +1
========================================
+ Hits 42903 43003 +100
- Misses 389 390 +1
Partials 156 156
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #11689 will not alter performanceComparing Summary
|
CHANGES/11689.contrib.rst
Outdated
@@ -0,0 +1 @@ | |||
Remove unused ``update-pre-commit`` github action -- by :user:`Cycloctane`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please avoid using imperative mood. Change log is neither a Git log, nor a TODO-list. Describe what changed, not a future plan.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, this is removing a workflow, not an action.
What do these changes do?
update-pre-commit is broken after #5261 due to the incorrect
github.repository_owner
condition. (See https://github.com/aio-libs/aiohttp/actions/workflows/update-pre-commit.yml). pre-commit auto update prs are actually created by pre-commit-ci app. This workflow is not needed anyway.