Skip to content

Update build requirements to setuptools-scm to >= 7.0.5 #955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Update build requirements to setuptools-scm to >= 7.0.5 #955

wants to merge 5 commits into from

Conversation

tjni
Copy link

@tjni tjni commented Aug 19, 2023 •
edited by webknjaz
Loading

What do these changes do?

Updates setuptools-scm >= 7.0.5 to remove setuptools-scm-git-archive. Supersedes #872 to try to get it over the finish line.

Related issue number

xref #745
Closes #872
Resolves #809

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

@codecov
Copy link

codecov bot commented Aug 19, 2023

Codecov Report

Merging #955 (fee997d) into master (83aa96e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #955   +/-   ##
=======================================
  Coverage   93.68%   93.68%           
=======================================
  Files          36       36           
  Lines        5538     5538           
  Branches      895      895           
=======================================
  Hits         5188     5188           
  Misses        260      260           
  Partials       90       90
Flag Coverage Δ
CI-GHA 93.28% <ø> (ø)
DB-mariadb-10.10 90.28% <ø> (ø)
DB-mariadb-10.11 90.28% <ø> (ø)
DB-mariadb-10.4 90.30% <ø> (ø)
DB-mariadb-10.5 90.28% <ø> (ø)
DB-mariadb-10.6 90.28% <ø> (ø)
DB-mariadb-10.9 90.28% <ø> (ø)
DB-mysql-5.7 90.98% <ø> (ø)
DB-mysql-8.0 92.41% <ø> (ø)
OS-Linux 93.28% <ø> (ø)
Py-3.10.11 ?
Py-3.10.12 93.15% <ø> (?)
Py-3.11.3 ?
Py-3.11.4 93.15% <ø> (?)
Py-3.7.16 ?
Py-3.7.17 92.78% <ø> (?)
Py-3.8.16 ?
Py-3.8.17 93.18% <ø> (?)
Py-3.9.16 ?
Py-3.9.17 93.05% <ø> (?)
VM-ubuntu-latest 93.28% <ø> (ø)
ubuntu-latest_3.10_mariadb-10.10 90.19% <ø> (ø)
ubuntu-latest_3.10_mariadb-10.11 90.19% <ø> (ø)
ubuntu-latest_3.10_mariadb-10.4 90.21% <ø> (ø)
ubuntu-latest_3.10_mariadb-10.5 90.19% <ø> (ø)
ubuntu-latest_3.10_mariadb-10.6 90.19% <ø> (ø)
ubuntu-latest_3.10_mariadb-10.9 90.19% <ø> (ø)
ubuntu-latest_3.10_mysql-5.7 90.89% <ø> (ø)
ubuntu-latest_3.10_mysql-8.0 92.28% <ø> (ø)
ubuntu-latest_3.11_mariadb-10.10 90.19% <ø> (ø)
ubuntu-latest_3.11_mariadb-10.11 90.19% <ø> (ø)
ubuntu-latest_3.11_mariadb-10.4 90.21% <ø> (ø)
ubuntu-latest_3.11_mariadb-10.5 90.19% <ø> (ø)
ubuntu-latest_3.11_mariadb-10.6 90.19% <ø> (ø)
ubuntu-latest_3.11_mariadb-10.9 90.19% <ø> (ø)
ubuntu-latest_3.11_mysql-5.7 90.89% <ø> (ø)
ubuntu-latest_3.11_mysql-8.0 92.28% <ø> (-0.04%) ⬇️
ubuntu-latest_3.7_mariadb-10.10 89.64% <ø> (ø)
ubuntu-latest_3.7_mariadb-10.11 89.64% <ø> (ø)
ubuntu-latest_3.7_mariadb-10.4 89.66% <ø> (ø)
ubuntu-latest_3.7_mariadb-10.5 89.64% <ø> (ø)
ubuntu-latest_3.7_mariadb-10.6 89.64% <ø> (ø)
ubuntu-latest_3.7_mariadb-10.9 89.64% <ø> (ø)
ubuntu-latest_3.7_mysql-5.7 90.39% <ø> (ø)
ubuntu-latest_3.7_mysql-8.0 91.86% <ø> (ø)
ubuntu-latest_3.8_mariadb-10.10 90.23% <ø> (ø)
ubuntu-latest_3.8_mariadb-10.11 90.23% <ø> (ø)
ubuntu-latest_3.8_mariadb-10.4 90.25% <ø> (ø)
ubuntu-latest_3.8_mariadb-10.5 90.23% <ø> (ø)
ubuntu-latest_3.8_mariadb-10.6 90.23% <ø> (ø)
ubuntu-latest_3.8_mariadb-10.9 90.23% <ø> (ø)
ubuntu-latest_3.8_mysql-5.7 90.94% <ø> (ø)
ubuntu-latest_3.8_mysql-8.0 92.31% <ø> (ø)
ubuntu-latest_3.9_mariadb-10.10 90.07% <ø> (ø)
ubuntu-latest_3.9_mariadb-10.11 90.07% <ø> (ø)
ubuntu-latest_3.9_mariadb-10.4 90.09% <ø> (ø)
ubuntu-latest_3.9_mariadb-10.5 90.07% <ø> (ø)
ubuntu-latest_3.9_mariadb-10.6 90.07% <ø> (ø)
ubuntu-latest_3.9_mariadb-10.9 90.07% <ø> (ø)
ubuntu-latest_3.9_mysql-5.7 90.77% <ø> (ø)
ubuntu-latest_3.9_mysql-8.0 92.18% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@webknjaz webknjaz linked an issue Mar 10, 2025 that may be closed by this pull request
setuptools_scm version 7 generates an incorrect version number for wheels #809
Open
@webknjaz webknjaz changed the title Update build-system requirements of setuptools-scm to >= 7.0.5 Update build requirements to setuptools-scm to >= 7.0.5 Mar 10, 2025
webknjaz
webknjaz reviewed Mar 10, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

setuptools_scm version 7 generates an incorrect version number for wheels
2 participants
@tjni @webknjaz