Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in ESLint invocation with TIMING env set #3047

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

steelbrain
Copy link
Contributor

Fixes #3045

Please see the linked issue for additional context. Here's copy-pasta of the report

In /whitespace.js a subprocess is launched to print out the rules in JSON and the JSON response is parsed.

If ESLint is being run with TIMING=1, it prints how much time each rule takes, and because the linked child process invocation is forwarding the env as-is, it's json parsing will fail and the process breaks down.

@ljharb ljharb merged commit f45bd1e into airbnb:master Oct 3, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eslint-config-airbnb breaks with TIMING=1 env
2 participants