Add parallel directory processing for faster formatting #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iron-Ham
force-pushed
the
feat/parallel-directory-formatting
branch
from
71d9ca2 to
8afc99b
Compare
Process multiple directories concurrently using Swift's TaskGroup, where each directory runs its full formatting pipeline independently: SwiftFormat → SwiftLint autocorrect → SwiftLint lint. ## Changes - Convert AirbnbSwiftFormatTool to AsyncParsableCommand - Add Command.runAsync() using Task.detached for true parallelism - Add DirectoryResult struct for per-directory exit code aggregation - Use withTaskGroup (not withThrowingTaskGroup) to process ALL directories even when some fail, giving users complete feedback - Add directory context to error messages (e.g., "Lint failures in: DirA, DirC") - Update tests to support async execution - Add tests for mixed success/failure scenarios across directories - Update ArgumentParser to 1.7.0 for AsyncParsableCommand support - Update minimum macOS to 10.15 for Swift Concurrency ## Benchmark Results (IronUI - 141 files, 3 directories) | Version | Wall-clock Time | Speedup | |------------|-----------------|--------------| | Sequential | 1.494s | baseline | | Parallel | 0.686s | 2.18x faster |
Iron-Ham
force-pushed
the
feat/parallel-directory-formatting
branch
from
8afc99b to
d6d3440
Compare
Member
|
Thanks for giving this a go! Appreciate the investigation.
Yeah, SwiftFormat spawns as many parallel threads as possible, so it makes sense that we've already achieved max parallelism. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Depends on #354
Processes multiple directories concurrently using
Taskgroup, where each directory runs its full formatting pipeline independently (SwiftFormat → SwiftLint autocorrect → SwiftLint lint).Key changes:
AsyncParsableCommandsupport.AirbnbSwiftFormatToolis updated to useAsyncParsableCommand.Reasoning
Hypothesis
For projects of a larger size than this one, the parallel approach would be significantly faster – especially for projects with many modules. Projects with few folders / files would still see higher performance from what's in
master.Experiment
Benchmark 5 runs of
mastervs this branch against my IronUI project.Results
Conclusion
No significant difference. I would have to imagine that both
SwiftFormatandSwiftLintare both highly parallel internally, regardless of what directories are passed to them as arguments. Probably should've looked into that before committing to this, but hey – learned something, I guess.