-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GDALViewshedGenerate binding #142
base: main
Are you sure you want to change the base?
Conversation
… > 3.10 (not sure about this approach...)
… compatible GDAL versions
… WILL run, but produces invalid test results
Question: Invalid test results across GDAL versionsI found in my testing that different versions of GDAL pass different sections of the test:
My solution for this is to return an error for any case where tests produce an invalid result, the current behaviour for the above is:
Do you prefer the approach I've implemented, which prevents the user from running |
… case in `TestViewshedCreationOptions`
GDALViewshedGenerate
bindingViewshed
go function (calls binding)TestViewshedSimpleHeight
to test the binding