Skip to content

ASRE-931: Add new variable shareProcessNamespace #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions charts/airbyte-bootloader/README.md
Original file line number Diff line number Diff line change
@@ -43,5 +43,6 @@ Helm chart to deploy airbyte-bootloader
| resources.limits | object | `{}` | |
| resources.requests | object | `{}` | |
| secrets | object | `{}` | |
| shareProcessNamespace | string | `"false"` | the shareProcessNamespace field is used in a PodSpec to enable all containers within a pod to share the same process namespace. This allows containers to view and interact with each other's processes. |
| tolerations | list | `[]` | |

3 changes: 3 additions & 0 deletions charts/airbyte-bootloader/templates/pod.yaml
Original file line number Diff line number Diff line change
@@ -18,6 +18,9 @@ metadata:
{{- include "common.tplvalues.render" (dict "value" .Values.podAnnotations "context" $) | nindent 4 }}
{{- end }}
spec:
{{- if .Values.shareProcessNamespace }}
shareProcessNamespace: true
{{- end }}
serviceAccountName: {{ .Values.global.serviceAccountName }}
{{- if .Values.global.imagePullSecrets }}
imagePullSecrets:
2 changes: 2 additions & 0 deletions charts/airbyte-bootloader/values.yaml
Original file line number Diff line number Diff line change
@@ -35,6 +35,8 @@ image:
repository: airbyte/bootloader
pullPolicy: IfNotPresent

shareProcessNamespace: false

## podAnnotations [object] Add extra annotations to the bootloader pod
##
podAnnotations: {}
10 changes: 5 additions & 5 deletions charts/airbyte-temporal-ui/templates/deployment.yaml
Original file line number Diff line number Diff line change
@@ -117,8 +117,8 @@ spec:
{{- if .Values.global.extraContainers }}
{{ toYaml .Values.global.extraContainers | nindent 6 }}
{{- end }}
securityContext: {{- toYaml .Values.podSecurityContext | nindent 8 }}
volumes:
{{- if .Values.extraVolumes }}
{{ toYaml .Values.extraVolumes | nindent 6 }}
{{- end }}
securityContext: {{- toYaml .Values.podSecurityContext | nindent 8 }}
volumes:
{{- if .Values.extraVolumes }}
{{ toYaml .Values.extraVolumes | nindent 6 }}
{{- end }}
4 changes: 2 additions & 2 deletions charts/airbyte/templates/_database.tpl
Original file line number Diff line number Diff line change
@@ -207,11 +207,11 @@ Renders all of the common environment variables which provide database credentia
Renders a set of database secrets to be included in the shared Airbyte secret
*/}}
{{- define "airbyte.database.secrets" }}
{{ $user := (include "airbyte.database.user" .)}}
{{ $user := (include "airbyte.database.user" .) | trim }}
{{- if not (empty $user) }}
DATABASE_USER: {{ $user }}
{{- end }}
{{ $password := (include "airbyte.database.password" .)}}
{{ $password := (include "airbyte.database.password" .) | trim }}
{{- if not (empty $password) }}
DATABASE_PASSWORD: {{ $password }}
{{- end}}
4 changes: 2 additions & 2 deletions charts/airbyte/templates/env-configmap.yaml
Original file line number Diff line number Diff line change
@@ -102,9 +102,9 @@ data:
JOB_MAIN_CONTAINER_MEMORY_LIMIT: {{ ((.Values.global.jobs.resources | default dict).limits | default dict).memory | default "" | quote }}
JOB_MAIN_CONTAINER_MEMORY_REQUEST: {{ ((.Values.global.jobs.resources | default dict).requests | default dict).memory | default "" | quote }}

{{- if $.Values.global.jobs.kube.main_container_image_pull_secret }}
{{- if and $.Values.global.jobs.kube.main_container_image_pull_secret (ne $.Values.global.jobs.kube.main_container_image_pull_secret "") }}
JOB_KUBE_MAIN_CONTAINER_IMAGE_PULL_SECRET: {{ $.Values.global.jobs.kube.main_container_image_pull_secret }}
{{- end }}
{{- end }}
JOBS_DATABASE_MINIMUM_FLYWAY_MIGRATION_VERSION: "0.29.15.001"

JOB_KUBE_LOCAL_VOLUME_ENABLED: {{ .Values.global.jobs.local.volume.enabled | quote }}
2 changes: 1 addition & 1 deletion charts/airbyte/templates/secret.yaml
Original file line number Diff line number Diff line change
@@ -15,4 +15,4 @@ stringData:
KEYCLOAK_ADMIN_USER: {{ .Values.keycloak.auth.adminUsername | quote }}
KEYCLOAK_ADMIN_PASSWORD: {{ .Values.keycloak.auth.adminPassword | quote }}
{{- end }}
WORKLOAD_API_BEARER_TOKEN: {{ index ".Values.workload-api.bearerToken" | quote }}
WORKLOAD_API_BEARER_TOKEN: {{ index .Values "workload-api-server" "bearerToken" | quote }}