Skip to content

Conversation

@electrum
Copy link
Member

No description provided.

Copy link

@Chaho12 Chaho12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any plans to merge this?

@electrum
Copy link
Member Author

This is currently several times slower than the JDK version that uses zlib, so I don't think we should merge this now.

@Chaho12
Copy link

Chaho12 commented Dec 15, 2023

How did you test and got results several times slower? TPC-H benchmark?
When I simply tested with this changes (note. i initialized with maxBuffersize), and did several tests with internal data including complex sqls with numerous joins, and simple ones with select count(*) from for reading orc zlib data, the results wasn't too bad. maximum of 20% slower?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants