Remove is_error invokation on function return with valid negative values #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martint
reviewed
Sep 25, 2024
jklamer
force-pushed
the
jklamer/NoIsErrorOnFrameSize
branch
from
f998484 to
852deaa
Compare
martint
reviewed
Sep 25, 2024
martint
reviewed
Sep 25, 2024
jklamer
force-pushed
the
jklamer/NoIsErrorOnFrameSize
branch
from
852deaa to
61ca938
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZSTD_isError()can be used to validate many output values of many methods, and is called out for those methods in the manual. It is not called out as being usable to validate the output ofZSTD_getFrameContentSizein that manual, and the method itself has valid negative returns for content size unknown.