Fix out-of-bounds read in ZstdIncrementalFrameDecompressor #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code branch is executed if there are less than SIZE_OF_INT bytes available, so it should not try to read an int then. That code apparently was only acting as assertion that the code is implemented correctly anyway. Note that in reality this out-of-bounds read most likely would have never happened because ZstdInputStream always provides it with a large enough buffer (unless users directly used ZstdIncrementalFrameDecompressor, which they probably shouldn't).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code branch is executed if there are less than SIZE_OF_INT bytes available, so it should not try to read an
intthen. That code apparently was only acting as assertion that the code is implemented correctly anyway.Note that in reality this out-of-bounds read most likely would have never happened because ZstdInputStream always provides it with a large enough buffer (unless users directly used ZstdIncrementalFrameDecompressor, which they probably shouldn't).
Edit: Or maybe this out-of-bounds read could occur, depending on how the data is laid out, and the sizes of the arrays.