Skip to content

IGNORE THIS#2

Open
Baalmart wants to merge 4 commits intostagingfrom
main
Open

IGNORE THIS#2
Baalmart wants to merge 4 commits intostagingfrom
main

Conversation

@Baalmart
Copy link
Contributor

@Baalmart Baalmart commented Sep 27, 2023

initial setup

Summary by CodeRabbit

  • Chores
    • Updated Next.js dependencies to the latest versions across multiple projects for improved stability and bug fixes.

✏️ Tip: You can customize this high-level summary in your review settings.

@vercel
Copy link
Contributor

vercel bot commented Nov 4, 2024

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
air-track Ready Ready Preview, Comment Feb 1, 2026 8:05pm
air-vista Ready Ready Preview, Comment Feb 1, 2026 8:05pm
breeze-mind Ready Ready Preview, Comment Feb 1, 2026 8:05pm
clean-aria Ready Ready Preview, Comment Feb 1, 2026 8:05pm
clean-stats Ready Ready Preview, Comment Feb 1, 2026 8:05pm
frontend Ready Ready Preview, Comment Feb 1, 2026 8:05pm
pure-sphere Ready Ready Preview, Comment Feb 1, 2026 8:05pm

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🧹 Nitpick comments (4)
clean-aria/package.json (1)

14-15: Next.js bump looks fine; consider bumping eslint-config-next in lockstep.
Right now it’s [email protected] with [email protected] (Line 20).

breathe-ui/package.json (1)

14-15: Dependency alignment suggestion: update eslint-config-next (and likely React types) alongside [email protected].
Helps avoid “works locally / fails in CI” lint/type mismatches.

pure-sphere/package.json (1)

14-15: Consider bumping eslint-config-next to match the Next.js patch.
[email protected] with [email protected] (Line 20) can lead to rule/behavior drift.

frontend/package.json (1)

34-35: Consider upgrading React to 19 for better Next.js 15 alignment.

The project uses React 18.3.1 with Next.js 15.1.11. While React 18 is compatible, Next.js 15 is optimized for and ships with React 19 support. React 19 brings new primitives (Actions, Suspense enhancements, useOptimistic) that align with Next.js 15's design philosophy.

Verify whether your team plans to upgrade React soon; if not, document the decision for future maintainers.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1e40832 and 7563ca8.

⛔ Files ignored due to path filters (9)
  • air-pulse/package-lock.json is excluded by !**/package-lock.json
  • air-track/package-lock.json is excluded by !**/package-lock.json
  • air-vista/package-lock.json is excluded by !**/package-lock.json
  • breathe-ui/package-lock.json is excluded by !**/package-lock.json
  • breeze-mind/package-lock.json is excluded by !**/package-lock.json
  • clean-aria/package-lock.json is excluded by !**/package-lock.json
  • clean-stats/package-lock.json is excluded by !**/package-lock.json
  • frontend/package-lock.json is excluded by !**/package-lock.json
  • pure-sphere/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (9)
  • air-pulse/package.json (1 hunks)
  • air-track/package.json (1 hunks)
  • air-vista/package.json (1 hunks)
  • breathe-ui/package.json (1 hunks)
  • breeze-mind/package.json (1 hunks)
  • clean-aria/package.json (1 hunks)
  • clean-stats/package.json (1 hunks)
  • frontend/package.json (1 hunks)
  • pure-sphere/package.json (1 hunks)
🔇 Additional comments (3)
air-vista/package.json (1)

14-15: LGTM on the patch bump; just watch the eslint-config-next mismatch.
If you’re standardizing on [email protected], I’d standardize eslint-config-next to the same patch too.

breeze-mind/package.json (1)

14-15: No action needed—versions are correctly aligned.

Both [email protected] and [email protected] share the same major version (15), which is the official requirement per Next.js docs. Patch-level differences within the same major version don't cause lint rule or version drift issues.

frontend/package.json (1)

32-32: Verify that the pinned Next.js version aligns with team versioning strategy.

The upgrade changes Next.js from a caret-managed range (^15.1.7) to a pinned version (15.1.11). Pinned versions require explicit manual updates for patch and minor releases, which can improve reproducibility but may slow security and bug-fix rollouts.

Confirm that this versioning strategy is intentional and documented in your team's dependency management guidelines.

Comment on lines 14 to 15
"next": "15.0.7"
},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

cat -n air-pulse/package.json

Repository: airqo-platform/code-samples

Length of output: 819


🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "=== Checking next versions ==="
curl -s https://registry.npmjs.org/next | jq -r '.["dist-tags"] | "Latest: \(.latest), Current: \(.current // "N/A")"'
curl -s https://registry.npmjs.org/next | jq -r '.versions | keys[] | select(startswith("15.0"))' | sort -V | tail -5

echo ""
echo "=== Checking eslint-config-next versions ==="
curl -s https://registry.npmjs.org/eslint-config-next | jq -r '.["dist-tags"] | "Latest: \(.latest)"'
curl -s https://registry.npmjs.org/eslint-config-next | jq -r '.versions | keys[] | select(startswith("15.0"))' | sort -V | tail -5

echo ""
echo "=== Verifying specific versions exist ==="
if curl -s https://registry.npmjs.org/next | jq -e '.versions["15.0.7"]' >/dev/null 2>&1; then
  echo "[email protected] exists"
else
  echo "[email protected] does NOT exist"
fi

if curl -s https://registry.npmjs.org/eslint-config-next | jq -e '.versions["15.0.3"]' >/dev/null 2>&1; then
  echo "[email protected] exists"
else
  echo "[email protected] does NOT exist"
fi

Repository: airqo-platform/code-samples

Length of output: 402


Dependency version skew requires alignment: [email protected] paired with [email protected].

The eslint-config-next package is four patch versions behind next. Since [email protected] exists on NPM, updating it to match next is straightforward.

Additionally, React 19 RC (19.0.0-rc-66855b96-20241106) is mismatched with @types/react and @types/react-dom both pinned to ^18. Either upgrade the type definitions to v19 or reconsider the React version choice.

🤖 Prompt for AI Agents
In air-pulse/package.json around lines 14 to 15, the peer dependency versions
are misaligned: update "eslint-config-next" to match the installed "next"
version (bump to 15.0.7) to remove the 4-patch skew, and resolve the
React/type-definition mismatch by either upgrading "@types/react" and
"@types/react-dom" to the compatible v19 release candidates that match "react":
"19.0.0-rc-..." or downgrade "react" to a stable v18 if you want to keep @types
pinned to ^18; adjust the package.json entries accordingly and run npm/yarn
install to lock the consistent versions.

Comment on lines 14 to 15
"next": "15.0.7"
},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🌐 Web query:

Next.js 15 React 19 peer dependencies required versions

💡 Result:

Next.js 15 requires React 19 — specifically the minimum versions of both react and react-dom are 19 (use matching React + ReactDOM releases). The Next.js upgrade docs recommend installing react@latest and react-dom@latest when moving to Next.js 15. [1][2]

Sources:

  • Next.js upgrade guide (Version 15) — minimum react/react-dom is 19. [1]
  • Next.js 15 release blog — aligns Next.js 15 with React 19 and recommends upgrading. [2]

🌐 Web query:

eslint-config-next 15.0.3 compatible Next.js versions

💡 Result:

[email protected] is the Next.js ESLint config for Next.js v15 — i.e., intended for Next.js 15.x releases. [1][2]

Sources:

  • Next.js (v15) ESLint docs. [1]
  • eslint-config-next package.json showing v15.x package metadata. [2]

🏁 Script executed:

# Let's check the actual package.json to see all relevant versions
head -30 air-track/package.json

Repository: airqo-platform/code-samples

Length of output: 637


Update @types/react and @types/react-dom to v19.

The runtime is correctly aligned (React 19 RC + Next.js 15.0.7 + eslint-config-next 15.0.3), but the type definitions are still pinned to v18. This mismatch will cause type errors during build and lint—update both to ^19 to match the runtime.

🤖 Prompt for AI Agents
In air-track/package.json around lines 14 to 15, the project pins @types/react
and @types/react-dom to v18 while runtime uses React 19/Next.js 15; update both
devDependencies to "^19" (or ^19.x) in package.json, run your package manager to
update the lockfile (npm install / pnpm install / yarn install), and
rebuild/lint to verify type errors are resolved; if any downstream types
conflict, update or pin compatible @types packages or replace with the
corresponding official types shipped with React 19.

Comment on lines 14 to 15
"next": "15.0.7"
},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🌐 Web query:

Next.js 15.0.7 eslint-config-next version alignment compatibility

💡 Result:

Short answer: Use the matching eslint-config-next 15.x that corresponds to your Next.js 15 release (e.g. [email protected]). The 15.x eslint-config-next releases are intended to align with Next.js 15 and declare peer support for ESLint ^7.23.0 || ^8.0.0 || ^9.0.0, so you can run ESLint 7, 8 or 9 with Next.js 15.0.7. [1][2]

Sources:

  • Next.js ESLint docs (Next.js v15) — explains eslint-config-next and ESLint 9 support. [1]
  • eslint-config-next package.json (15.x) showing peerDependencies: eslint ^7.23.0 || ^8.0.0 || ^9.0.0. [2]

🌐 Web query:

React 19 RC @types/react 18 compatibility TypeScript types

💡 Result:

Short answer: React 19 RC’s types are not fully compatible with the published @types/react v18 ecosystem — you must use the React‑19 RC types (the temporary packages mapped to types-react@rc / types-react-dom@rc) or apply overrides/resolutions, or else you’ll see TypeScript errors in downstream libs. Common workarounds are installing the RC types per the React 19 upgrade guide, using package overrides/ resolutions (or npm: aliasing) to force the RC @types, or falling back to skipLibCheck until dependent libraries update. [1][2][3][4]

What to do now (options)

  • Follow the React 19 Upgrade Guide and install the RC types (example mapping shown there: "@types/react": "npm:types-react@rc", "@types/react-dom": "npm:types-react-dom@rc", with overrides). This is the supported approach for RC testing. [1]
  • If you can’t update types everywhere yet, use package manager overrides / yarn/npm resolutions or an npm alias to force a single @types/react version across node_modules. [2][4]
  • As a quick temporary fix: set "skipLibCheck": true in tsconfig to avoid type errors from un-updated libraries (not recommended as a long‑term solution). [3][4]

Why this is needed

  • React 19 moves/changes TypeScript/JSX typings (removes global JSX namespace and other breaking changes), so many libraries that expect the old @types/react shape will error until they update. See reported issues (i18next, Next.js, MUI, etc.). [3][2][4]

If you want, tell me:

  • whether you’re using npm/yarn/pnpm and CI (e.g. Vercel); I’ll give the exact package.json override/resolution or alias command to apply.

Align eslint-config-next and React type packages with your upgraded versions.

You bumped next to 15.0.7, but eslint-config-next is still pinned to 15.0.3 (Line 24). Next.js 15.x releases are designed to align with their corresponding eslint-config-next versions—use 15.0.7 to match your Next.js version and avoid linting inconsistencies.

Additionally, React 19 RC introduces breaking TypeScript changes (like removing the global JSX namespace), and @types/react@18 is incompatible with it. You'll hit TypeScript errors unless you either:

  • Use the React 19 RC types via npm:types-react@rc and npm:types-react-dom@rc with overrides/resolutions
  • Or apply package manager resolutions to force a consistent version across dependencies

Update both the eslint config version and React types to resolve these compatibility issues.

🤖 Prompt for AI Agents
In clean-stats/package.json around lines 14 to 24, your Next version was bumped
to 15.0.7 but eslint-config-next remains at 15.0.3 and
@types/react/@types/react-dom are still at 18, which will cause lint and
TypeScript incompatibilities with React 19 RC; update "eslint-config-next" to
"15.0.7" to match Next, and either set @types/react and @types/react-dom to the
React 19 RC packages (use the npm alias like npm:types-react@rc and
npm:types-react-dom@rc) or add package-manager-specific overrides/resolutions to
force the RC types across the dependency tree so TypeScript sees the correct
React 19 typings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants