feat: move NoOpCliktCommand from clikt-mordant to clikt module #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow using it for both
|
Good catch! Since this changes the public API, can you run |
|
The task |
|
Thanks! None of the docs mention which module it belongs to, so I don't thing anything needs to change there. Since the core module hasn't been released yet, we don't need to make a changelog entry. |
ajalt
added a commit
that referenced
this pull request
Jul 14, 2024
#526 Made the `NoOpCliktCommand` available in `core`, and this PR follows up by renaming it to match the other core commands and making a separate command that uses mordant. While it is a bit annoying to need separate copies of all the commands just to install mordant, I don't know of a better solution that works an all multiplatform targets.
|
Thank you for merging this PR as well for maintaining the project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
NoOpCliktCommandclass fromclikt-mordanttocliktmodule to allow use it for bothI'm uncertain if there is a reason why this class is in the
clikt-mordantmodule though it seems that the classNoOpCliktCommanddoes not use any Mordant-specific implementation, moving it to thecliktmodule to allow the use of it when usingclikt-corewithout a breaking change. This should work for bothcliktandclikt-mordant.We might need to update the docs in case something got outdated, or if there is not, we might want to consider documenting this change.