Skip to content

Conversation

@skrivy
Copy link

@skrivy skrivy commented Nov 23, 2018

Problematic situation:

class { 'supervisord':
    ...
    config_include       => '/etc/supervisor/conf.d',
    config_include_purge => true,
    ...
}

If we remove any supervisord::program block with this configuration, it's .conf file gets deleted, but supervisord process is not reloaded and removed program remains running.

This patch reconfigures supervisord on the conf directory content change.

@quanghiem
Copy link
Contributor

By notifying supervisord::service, puppet will restart the supervisord service on any config change. This should notify supervisord::reload instead so that puppet issues a supervisorctl reread and update instead to avoid any downtime.

@skrivy
Copy link
Author

skrivy commented Dec 5, 2018

@quanghiem Feel free to update the PR.

@quanghiem
Copy link
Contributor

@skrivy I don't think people can add commits to your PR.

@ajcurated
Copy link
Owner

Sorry for the slow reply guys

If @skrivy wants to close this and @quanghiem you want to propose a new PR based on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants