Skip to content

Failing reserves invariant after bucket take #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Failing reserves invariant after bucket take #1055

wants to merge 10 commits into from

Conversation

@prat-gpt
Copy link
Contributor

@prat-gpt prat-gpt commented Jan 9, 2024

Description

  • Some reserves invariant failed after bucketTake when reserves were too large (>~1e30). Added following failing reserves invariant regressions.
  • Fix failing regressions by updating reservesErrorMargin = (reservesAfterAction + reservesBeforeAction) / 1e16
  • Reset reservesErrorMargin before each handler calls in invariant.

Purpose

Impact

Tasks

  • Changes to protocol contracts are covered by unit tests executed by CI.
  • Protocol contract size limits have not been exceeded.
  • Gas consumption for impacted transactions have been compared with the target branch, and nontrivial changes cited in the Impact section above.
  • Scope labels have been assigned as appropriate.
  • Invariant tests have been manually executed as appropriate for the nature of the change.

@prat-gpt
Copy link
Contributor Author

prat-gpt commented Jan 9, 2024

PR #1054 needs to be merged, before merging this into develop.

@prateek105
Invariants Improvement (#1054)
f0b163c 
* Reduce max pool debt in invariants to 1e32 and add loans settlement for kicked borrowers if pool debt is greater than max pool debt

* Fix collateral to pledge in erc20 invariants
ith-harvey
ith-harvey approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@ith-harvey ith-harvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ith-harvey ith-harvey ith-harvey approved these changes

@EdNoepel EdNoepel EdNoepel approved these changes

@grandizzy grandizzy Awaiting requested review from grandizzy

@MikeHathaway MikeHathaway Awaiting requested review from MikeHathaway

@mattcushman mattcushman Awaiting requested review from mattcushman

At least 3 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Scope: Tests Status: Ready for Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@prat-gpt @ith-harvey @EdNoepel @grandizzy @prateek105