Skip to content

pass the wavelengths object, not the concat'ed wavelengths #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 8, 2025

Conversation

ajwheeler
Copy link
Owner

Fix bug where synth would error when using noncontiguous wavelengths and nonzero vsini at the same time.

Copy link
Contributor

github-actions bot commented Jul 1, 2025

Benchmark Results (Julia v1)

Time benchmarks
main ef14df8... main / ef14df8...
synthesis/M dwarf/100 Å of APOGEE w/ water 7.41 ± 0.0035 s 7.6 ± 0.03 s 0.975 ± 0.0039
synthesis/M dwarf/4000 Å - 8000 Å VALD solar 12.6 ± 0.056 s 12.7 ± 0.12 s 0.989 ± 0.01
synthesis/M dwarf/APOGEE DR17 w/o water 9.51 ± 0.04 s 9.58 ± 0.039 s 0.993 ± 0.0059
synthesis/M dwarf/one wavelength 0.31 ± 0.0011 s 0.334 ± 0.012 s 0.929 ± 0.034
synthesis/sun/100 Å of APOGEE w/ water 0.855 ± 0.0057 s 0.851 ± 0.0016 s 1.01 ± 0.007
synthesis/sun/4000 Å - 8000 Å VALD solar 5.6 ± 0.032 s 5.66 ± 0.051 s 0.99 ± 0.01
synthesis/sun/APOGEE DR17 w/o water 4.87 ± 0.024 s 4.94 ± 0.04 s 0.987 ± 0.0094
synthesis/sun/one wavelength 0.119 ± 0.00042 s 0.121 ± 0.0012 s 0.983 ± 0.01
time_to_load 2.75 ± 0.0073 s 2.79 ± 0.087 s 0.987 ± 0.031
Memory benchmarks
main ef14df8... main / ef14df8...
synthesis/M dwarf/100 Å of APOGEE w/ water 1.73 M allocs: 3.21 GB 1.73 M allocs: 3.21 GB 1
synthesis/M dwarf/4000 Å - 8000 Å VALD solar 8.62 M allocs: 7.11 GB 8.62 M allocs: 7.11 GB 1
synthesis/M dwarf/APOGEE DR17 w/o water 5.6 M allocs: 5.11 GB 5.6 M allocs: 5.11 GB 1
synthesis/M dwarf/one wavelength 1.15 M allocs: 0.288 GB 1.15 M allocs: 0.288 GB 1
synthesis/sun/100 Å of APOGEE w/ water 1.17 M allocs: 0.226 GB 1.17 M allocs: 0.226 GB 1
synthesis/sun/4000 Å - 8000 Å VALD solar 8.48 M allocs: 2.81 GB 8.48 M allocs: 2.81 GB 1
synthesis/sun/APOGEE DR17 w/o water 5.29 M allocs: 2.12 GB 5.29 M allocs: 2.12 GB 1
synthesis/sun/one wavelength 0.782 M allocs: 0.107 GB 0.782 M allocs: 0.107 GB 1
time_to_load 0.159 k allocs: 11.2 kB 0.159 k allocs: 11.2 kB 1

@ajwheeler ajwheeler merged commit d9bdef0 into main Jul 8, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant