Skip to content

Conversation

akade
Copy link
Owner

@akade akade commented Aug 25, 2025

Spatial index based on R*Tree with a focus on query performance (area intersection & nearest neighbors)

@akade akade requested a review from Copilot August 25, 2025 20:06
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces spatial indexing capabilities for Vector2 and Vector3 data types using a generic R*Tree implementation. The spatial index provides efficient area intersection queries and nearest neighbor search functionality for 2D and 3D vector data.

Key changes include:

  • Implementation of R*Tree data structure with support for Vector2 and Vector3 geometries
  • Addition of WithSpatialIndex builder method and NearestNeighbors query method to the public API
  • Optimization of internal index operations using new key-value enumerator abstractions

Reviewed Changes

Copilot reviewed 44 out of 46 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
DataStructures/RTree/ Complete R*Tree implementation with Vector2/Vector3 math support
Indices/SpatialIndex.cs Spatial index implementation wrapping the R*Tree
IndexedSetBuilder.cs Added WithSpatialIndex method for Vector2/Vector3 types
IndexedSet.cs Added NearestNeighbors query method for spatial searches
Utils/ Key-value enumerator abstraction for optimized index operations
Source generator files Added System.Numerics using statements for Vector2/Vector3 support

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@akade akade requested a review from Copilot October 8, 2025 19:58
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 73 out of 75 changed files in this pull request and generated 9 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@akade akade requested a review from Copilot October 9, 2025 19:02
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@akade akade requested a review from Copilot October 11, 2025 18:10
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 101 out of 103 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@akade akade merged commit 0757527 into main Oct 11, 2025
3 checks passed
@akade akade deleted the feature/rstartree branch October 11, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant