-
-
Notifications
You must be signed in to change notification settings - Fork 6
Spatial index based on a generic R*Tree for Vector2 & Vector3 #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces spatial indexing capabilities for Vector2 and Vector3 data types using a generic R*Tree implementation. The spatial index provides efficient area intersection queries and nearest neighbor search functionality for 2D and 3D vector data.
Key changes include:
- Implementation of R*Tree data structure with support for Vector2 and Vector3 geometries
- Addition of
WithSpatialIndex
builder method andNearestNeighbors
query method to the public API - Optimization of internal index operations using new key-value enumerator abstractions
Reviewed Changes
Copilot reviewed 44 out of 46 changed files in this pull request and generated 5 comments.
Show a summary per file
File | Description |
---|---|
DataStructures/RTree/ |
Complete R*Tree implementation with Vector2/Vector3 math support |
Indices/SpatialIndex.cs |
Spatial index implementation wrapping the R*Tree |
IndexedSetBuilder.cs |
Added WithSpatialIndex method for Vector2/Vector3 types |
IndexedSet.cs |
Added NearestNeighbors query method for spatial searches |
Utils/ |
Key-value enumerator abstraction for optimized index operations |
Source generator files | Added System.Numerics using statements for Vector2/Vector3 support |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 73 out of 75 changed files in this pull request and generated 9 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 101 out of 103 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Spatial index based on R*Tree with a focus on query performance (area intersection & nearest neighbors)