Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added EdgeKV lib d.ts module. #142

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added EdgeKV lib d.ts module. #142

wants to merge 1 commit into from

Conversation

shigeyf
Copy link

@shigeyf shigeyf commented Mar 9, 2022

No description provided.

@mryakan mryakan assigned kayoub-akamai and unassigned mryakan Jun 10, 2022
kayoub-akamai
kayoub-akamai requested changes Jun 10, 2022
View reviewed changes
Copy link
Collaborator

@kayoub-akamai kayoub-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added comments where I think things might not be accurate... I'm curious how we expect customers to use this file?

edgekv/lib/edgekv.d.ts
group?: string;
item: string;
value: T;
timeout?: number;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't this be null too?

edgekv/lib/edgekv.d.ts
namespace?: string;
group?: string;
item: string;
timeout?: number | null;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't think this one has a timeout?

edgekv/lib/edgekv.d.ts
}

export declare class EdgeKV {
constructor(namespace?: string, group?: string, num_retries_on_timeout?: number);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to indicate this, but it takes two constructors:

  1. is constructor(namespace?: string, group?: string)
  2. is constructor(item: EdgeKVConstructor)
    where
    interface EdgeKVConstructor {
    namespace?: string;
    group?: string;
    num_retries_on_timeout?: number;
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayoub-akamai kayoub-akamai kayoub-akamai requested changes

Assignees

@kayoub-akamai kayoub-akamai

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shigeyf @kayoub-akamai @mryakan