Support bash set -u / nounset (unset noun) checks #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly assigned positional arguments in some functions to named variables, defaulting to an empty string if undefined. This aides readability in some places, and prevents errors with omission of optional arguments when using bash's "set -u" / nounset shell attribute.
Added some missing quotes that would have caused syntax errors or unexpected argument shifts with unset variables.
Explicitly added assignment of empty lists () on initial array and associative array declaration to avoid unexpected behaviour with slightly older bash < 4.3 versions.
Removed explicit set -u and set +u statements as they have no business being in a library. ;-)