util (ble/util/load-standard-builtin): actually load from $loadable_path #611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, thanks. This is an oversight in the recent modification 044c016. |
|
Thank you for identifying the cause and fixing it! I've merged it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm pretty sure the way this is currently written all possible
${loadable_paths[@]}are checked for a valid builtin... only to then completely ignore the checks and load from$bash_prefix/lib/bash/. It should probably load from the just validated$loadable_path.Noticed this because on my system builtins are in
/usr/lib64/bash/so the checks passed for that directory.ble.shthen "loaded" the wrong builtins which resulted in every call to them printingbash: builtin: xxxxx: not a shell builtinto the console.