set settings.infinite false when number of children <= slidesToShow to fix slick cloned slides bug#2114
Open
FlorineC wants to merge 1 commit intoakiran:masterfrom
Open
set settings.infinite false when number of children <= slidesToShow to fix slick cloned slides bug#2114FlorineC wants to merge 1 commit intoakiran:masterfrom
FlorineC wants to merge 1 commit intoakiran:masterfrom
Conversation
…o fix slick cloned slides bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1569
I kept the functionality of setting the unslick to true when the number of children is inferior or equal to the number of slides to show. I set infinite to false to avoid the duplicates.
Example with 4 children and slidesToShow: 5.
Before:
After:
