-
Notifications
You must be signed in to change notification settings - Fork 639
Updates Couchbase integration to support collections #3396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…se dependencies; Tests are passing but I need to add more coverage.
Hi @chedim, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Akka Contributors License Agreement: |
Working on it. Hopefully, it'll not take long 🤞 |
...hbase/src/main/scala/akka/stream/alpakka/couchbase/impl/CouchbaseCollectionSessionImpl.scala
Outdated
Show resolved
Hide resolved
Hi @chedim, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Akka Contributors License Agreement: |
We have received the CLA. |
We signed the CLA. Authorized logins: chedim and deniswrosa |
Closing and re-opening to trigger the CLA validator again. |
@ennru @sebastian-alfers @leviramsey Could somebody please review the PR whenever they get a chance? Thank you! |
References #3395
This PR introduces new
CouchbaseCollectionSession
class that can be accessed fromCouchbaseSession
viaCouchbaseSession::collection
method. It also updates sinks, sources and flow constructors and their signatures to work with collections.All of these are breaking changes.
Please note that, although fascinated by the framework and some language features, I am not very familiar with either alpakka or scala and more of a Java dev. So, any suggestions on how to improve my changes are greatly appreciated.
Cheers!