Skip to content

Updates Couchbase integration to support collections #3396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

chedim
Copy link

@chedim chedim commented May 8, 2025

References #3395

This PR introduces new CouchbaseCollectionSession class that can be accessed from CouchbaseSession via CouchbaseSession::collection method. It also updates sinks, sources and flow constructors and their signatures to work with collections.

All of these are breaking changes.

Please note that, although fascinated by the framework and some language features, I am not very familiar with either alpakka or scala and more of a Java dev. So, any suggestions on how to improve my changes are greatly appreciated.

Cheers!

…se dependencies; Tests are passing but I need to add more coverage.
@lightbend-cla-validator
Copy link

Hi @chedim,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Akka Contributors License Agreement:

https://www.lightbend.com/contribute/cla

@probot-autolabeler probot-autolabeler bot added dependency-change For PRs changing the version of a dependency. p:couchbase labels May 8, 2025
@chedim
Copy link
Author

chedim commented May 8, 2025

Hi @chedim,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Akka Contributors License Agreement:

https://www.lightbend.com/contribute/cla

Working on it. Hopefully, it'll not take long 🤞

@lightbend-cla-validator

Hi @chedim,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Akka Contributors License Agreement:

https://www.lightbend.com/contribute/cla

@ennru
Copy link
Contributor

ennru commented Jun 2, 2025

We have received the CLA.

@chedim
Copy link
Author

chedim commented Jun 3, 2025

We signed the CLA. Authorized logins: chedim and deniswrosa

@sebastian-alfers
Copy link
Contributor

Closing and re-opening to trigger the CLA validator again.

@chedim chedim marked this pull request as ready for review June 30, 2025 14:39
@chedim chedim requested a review from leviramsey July 1, 2025 16:45
@chedim
Copy link
Author

chedim commented Jul 10, 2025

@ennru @sebastian-alfers @leviramsey Could somebody please review the PR whenever they get a chance? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency-change For PRs changing the version of a dependency. p:couchbase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants