Added reproduction spec for missing custom mailbox when using DI #7402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
added
confirmed bug
akka-actor
configuration
akka-dependency-injection
Aaronontheweb
commented
Dec 4, 2024
| @@ -10,6 +10,7 @@ | |||
| [assembly: System.Runtime.CompilerServices.InternalsVisibleToAttribute("Akka.Cluster.Tests.MultiNode")] | |||
| [assembly: System.Runtime.CompilerServices.InternalsVisibleToAttribute("Akka.Cluster.Tools")] | |||
| [assembly: System.Runtime.CompilerServices.InternalsVisibleToAttribute("Akka.DependencyInjection")] | |||
| [assembly: System.Runtime.CompilerServices.InternalsVisibleToAttribute("Akka.DependencyInjection.Tests")] | |||
There was a problem hiding this comment.
Had to expose friend assembly bits here in order to make the test workable, and that's what triggered the API check-in.
Aaronontheweb
commented
Dec 4, 2024
|
|
||
| // Verify that the custom mailbox was used | ||
| var actorRef = (RepointableActorRef)actor; | ||
| actorRef.MailboxType.GetType().Should().Be(typeof(CustomMailbox)); |
There was a problem hiding this comment.
Fixed how we assert for the presence of the custom mailbox to match what we do in the core AkkaSpecs and this passes now - I was also able to verify with the debugger that the custom mailbox was used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Based on this Discord thread, https://discord.com/channels/974500337396375553/1313882787350188124 - it looks like there's a bug with using custom mailboxes with DI'd actors. This PR tests for the issue.
Ultimately we were not able to reproduce it after we corrected the test assertion for the custom mailbox.