Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better perf in HandleStashedInbound #7409

Merged
merged 2 commits into from
Dec 18, 2024
Merged

better perf in HandleStashedInbound #7409

merged 2 commits into from
Dec 18, 2024

Conversation

SimonCropp
Copy link
Contributor

  • remove 1 dictionary lookup. since previously GetOrElse and Remove are a dictionary lookup
  • remove redundant list allocation
  • remove redundant enumeration over the above empty list

Aaronontheweb
Aaronontheweb approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb
Copy link
Member

Test failure was not related to this spec - it's an Akka.Streams spec that's tightly bounded to timings, which makes it somewhat inherently racy.

@Aaronontheweb Aaronontheweb merged commit 21ee0c4 into akkadotnet:dev Dec 18, 2024
10 of 12 checks passed
@Arkatufus Arkatufus mentioned this pull request Dec 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
akka-remote perf
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonCropp @Aaronontheweb