Make actor start / stop telemetry descriptors overrideable #7434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
commented
Dec 23, 2024
| /// <summary> | ||
| /// Overrideable in order to support issues such as https://github.com/petabridge/phobos-issues/issues/82 | ||
| /// </summary> | ||
| protected virtual ActorStarted CreateActorStartedEvent() |
There was a problem hiding this comment.
Going to customize these events mostly to support F# users, since Akkling actors all use the same base type, this should make them easier to distinguish in Phobos traces and metrics in the future.
| @@ -94,6 +94,8 @@ namespace Akka.Actor | |||
| public void CheckReceiveTimeout(bool reschedule = True) { } | |||
| protected void ClearActor(Akka.Actor.ActorBase actor) { } | |||
| protected void ClearActorCell() { } | |||
| protected virtual Akka.Actor.ActorStarted CreateActorStartedEvent() { } | |||
There was a problem hiding this comment.
Part of the public API but only gets access by components that use custom ActorCells, which are rare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Designed to support petabridge/phobos-issues#82
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):