Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IShardingMessageAdapter #7441

Merged

Conversation

Arkatufus
Copy link
Contributor

@Arkatufus Arkatufus commented Jan 2, 2025

Changes

Add IShardingMessageAdapter interface to Akka.Cluster.Sharding to allow tracing data to be preserved when sharding messages are buffered

Checklist

For significant changes, please ensure that the following have been completed (delete if not relevant):

Copy link
Contributor Author

@Arkatufus Arkatufus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review

{
}

public object Adapt(object message) => message;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method will be used to transform a message before it is stored inside the buffer.

namespace Akka.Cluster.Sharding;

[InternalApi]
public class ShardingSetup: Setup
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This setup class will be used to inject a message adapter into both the ShardRegion and Shard actor during initialization

@Arkatufus Arkatufus marked this pull request as ready for review January 3, 2025 20:15
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb merged commit e425975 into akkadotnet:dev Jan 6, 2025
12 checks passed
@Aaronontheweb Aaronontheweb added this to the 1.5.34 milestone Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants