Fix Shard failed to unwrap buffered messages correctly
#7452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related: petabridge/phobos-issues#84 |
….com:Arkatufus/akka.net into Fix-Shard-failed-to-unwrap-buffered-messages
Aaronontheweb
requested changes
Jan 10, 2025
| { | ||
| return message switch | ||
| { | ||
| Message m => m.Payload, |
There was a problem hiding this comment.
This is kind of testing the wrong thing here - the Unapply method should be handling this.
There was a problem hiding this comment.
no its not, we're testing MyEnvelope, that Message class is the actual message being sent, not a string.
There was a problem hiding this comment.
actually, you're right, there's something wrong with the repro code
Aaronontheweb
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):