Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IMP add an explicit notification message (printer name for example) #318

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

IMP add an explicit notification message (printer name for example) #318

wants to merge 1 commit into from

Conversation

mourad-ehm
Copy link
Member

hparfr
hparfr requested changes Nov 6, 2024
View reviewed changes
Copy link
Member

@hparfr hparfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it helps the review when you tell us "why" you are introducing a change

proxy_action/models/helper.py
@@ -21,8 +21,9 @@ def get_print_data_action(
to_encode64=False,
copies=1,
host="https://localhost",
msg="Your action is being executed",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no translation anymore ?

proxy_action/static/src/js/proxy_view.esm.js
@@ -4,7 +4,11 @@ import {registry} from "@web/core/registry";

async function executeProxyAction({env, action}) {
action.action_list.map(function (act) {
env.services.notification.add(env._t("Your action is being executed"), {
let msg = "Your action is being executed";
if (act.params.args && act.params.args[2] !== undefined) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use kwargs ?

proxy_action/static/src/js/proxy_view.esm.js
@@ -4,7 +4,11 @@ import {registry} from "@web/core/registry";

async function executeProxyAction({env, action}) {
action.action_list.map(function (act) {
env.services.notification.add(env._t("Your action is being executed"), {
let msg = "Your action is being executed";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is defined twice and no more translation

@bealdav
Copy link
Member

bealdav commented Nov 6, 2024

Thanks for the review @hparfr .

@mourad-ehm could you fix it ? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hparfr hparfr hparfr requested changes

@florian-dacosta florian-dacosta Awaiting requested review from florian-dacosta

@sebastienbeau sebastienbeau Awaiting requested review from sebastienbeau

@Kev-Roche Kev-Roche Awaiting requested review from Kev-Roche

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mourad-ehm @bealdav @hparfr @github-grap-bot