Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): update to angular 16 #3222

Merged
merged 13 commits into from
Nov 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,11 @@
"rules": {
"quotes": "off",
"dot-notation": "off",
"no-restricted-globals": ["error", "fit", "fdescribe"],
"no-restricted-globals": [
"error",
"fit",
"fdescribe"
],
"@typescript-eslint/dot-notation": "error",
"no-shadow": "off",
"@typescript-eslint/no-shadow": "error",
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/deploy-docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ jobs:
deploy-docs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '14'
node-version: 16.14.0
cache: 'npm'
- run: npm ci
- run: npm run docs:gh-pages
36 changes: 18 additions & 18 deletions .github/workflows/pr-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ jobs:
build-packages:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '16'
node-version: 16.14.0
cache: 'npm'
- run: npm ci
- run: npm run build:packages
Expand All @@ -24,10 +24,10 @@ jobs:
build-packages-rxjs-7:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '16'
node-version: 16.14.0
cache: 'npm'
- run: |
npm ci
Expand All @@ -37,20 +37,20 @@ jobs:
needs: build-packages
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '16'
node-version: 16.14.0
- run: npm ci
- run: npm run docs:build
build-playground:
needs: build-packages
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '16'
node-version: 16.14.0
- run: npm ci
- uses: actions/download-artifact@v2
with:
Expand Down Expand Up @@ -101,10 +101,10 @@ jobs:
BSU: debac1
BSK: AhrdZMi5gFDy3CQQfJHs
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '16'
node-version: 16.14.0
- run: npm ci
- uses: actions/download-artifact@v2
with:
Expand Down Expand Up @@ -133,10 +133,10 @@ jobs:
needs: build-packages
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '16'
node-version: 16.14.0
- uses: actions/download-artifact@v2
with:
name: built-packages
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16.13.0
16.14.0
5 changes: 3 additions & 2 deletions angular.json
Original file line number Diff line number Diff line change
Expand Up @@ -606,7 +606,6 @@
}
}
},
"defaultProject": "playground",
"schematics": {
"@schematics/angular:component": {
"style": "scss",
Expand All @@ -624,6 +623,8 @@
},
"cli": {
"analytics": false,
"defaultCollection": "@angular-eslint/schematics"
"schematicCollections": [
"@angular-eslint/schematics"
]
}
}
1 change: 0 additions & 1 deletion docs/app/app.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ import * as docs from '../output.json';
],
declarations: [NgdAppComponent],
providers: [Title, { provide: STRUCTURE, useValue: structure }, { provide: DOCS, useValue: docs }],
entryComponents: [],
bootstrap: [NgdAppComponent],
})
export class AppModule {}
Loading
Loading