Skip to content

feat: update to Angular 17 #3236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jan 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/deploy-docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16.14.0
node-version: 18.13.0
cache: 'npm'
- run: npm ci
- run: npm run docs:gh-pages
12 changes: 6 additions & 6 deletions .github/workflows/pr-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16.14.0
node-version: 18.13.0
cache: 'npm'
- run: npm ci
- run: npm run build:packages
Expand All @@ -27,7 +27,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16.14.0
node-version: 18.13.0
cache: 'npm'
- run: |
npm ci
Expand All @@ -40,7 +40,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16.14.0
node-version: 18.13.0
- run: npm ci
- run: npm run docs:build
build-playground:
Expand All @@ -50,7 +50,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16.14.0
node-version: 18.13.0
- run: npm ci
- uses: actions/download-artifact@v2
with:
Expand Down Expand Up @@ -104,7 +104,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16.14.0
node-version: 18.13.0
- run: npm ci
- uses: actions/download-artifact@v2
with:
Expand Down Expand Up @@ -136,7 +136,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16.14.0
node-version: 18.13.0
- uses: actions/download-artifact@v2
with:
name: built-packages
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16.14.0
18.13.0
12 changes: 10 additions & 2 deletions docs/app/app.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* Copyright Akveo. All Rights Reserved.
* Licensed under the MIT License. See License.txt in the project root for license information.
*/
import { BrowserModule, Title } from '@angular/platform-browser';
import { BrowserModule, REMOVE_STYLES_ON_COMPONENT_DESTROY, Title } from '@angular/platform-browser';
import { BrowserAnimationsModule } from '@angular/platform-browser/animations';
import { NgModule } from '@angular/core';
import { FormsModule } from '@angular/forms';
Expand Down Expand Up @@ -48,7 +48,15 @@ import * as docs from '../output.json';
RouterModule.forRoot(routes, { useHash: false }),
],
declarations: [NgdAppComponent],
providers: [Title, { provide: STRUCTURE, useValue: structure }, { provide: DOCS, useValue: docs }],
providers: [
Title,
{ provide: STRUCTURE, useValue: structure },
{ provide: DOCS, useValue: docs },
{
provide: REMOVE_STYLES_ON_COMPONENT_DESTROY,
useValue: false,
}
],
bootstrap: [NgdAppComponent],
})
export class AppModule {}
Loading