-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update newcommitter.md #88
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cswjd
commented
Feb 28, 2023
- [相关链接(建议)]:Issue [翻译] ASF 新Committer 指导文档 #87
- [描述信息(可选)]:
- [备注说明(可选)]:
ShawnJim
reviewed
Feb 28, 2023
ShawnJim
reviewed
Feb 28, 2023
tuohai666
suggested changes
Feb 28, 2023
tuohai666
suggested changes
Feb 28, 2023
6freeair2016
suggested changes
Mar 1, 2023
cswjd
requested review from
6freeair2016 and
ShawnJim
and removed request for
tuohai666 and
6freeair2016
March 2, 2023 04:59
cswjd
commented
Mar 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
cswjd
commented
Mar 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
Thanks the contribution of @l-y-l and the review work of @tuohai666, @ShawnJim, @6freeair2016, @WillemJiang |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.