This repository has been archived by the owner on Sep 4, 2018. It is now read-only.
Update git submodules when updating plugins #484
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #454, plugins using git submodules need to run
git submodule update
after afetch
to update their dependencies to the right commit.This is also related to #465, which fixed the initial clone for plugins using submodules.
Changes:
--recurse-submodules=on-demand
to thefetch
command to recursively fetch submodules commits;git submodule update
after successfulgit fetch
andgit reset --hard
to make the submodules checkout the right commits.Note: Not a big fan of the pyramid-callbacks-style in
+[ATZGit updateLocalProject:revision:completion:]
, if you have a better idea, I'll take it :)