-
Notifications
You must be signed in to change notification settings - Fork 164
feat: add jwt as auth method #1474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@archit2407 is attempting to deploy a commit to the Alchemy Team on Vercel. A member of the Team first needs to authorize it. |
How to use the Graphite Merge QueueAdd the label graphite-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
jwt: args.jwt, | ||
targetPublicKey, | ||
authProvider: args.authProvider, | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't necessarily a problem to solve in this PR, but I'm feeling there's a fair bit of code duplication between the react native and web signer clients. The implementation of submitJwt
here in the web client is identical to the implementation in the react native client, except for changing this.stamper.init()
to this.initIFrameStamper()
, and this holds for some of the other methods in these files as well. Could be a good cleanup to do later. cc @moldy530 in case I'm missing something about this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is absolutely true. A lot of room for creating helpers in base and use it both places. But as you said lets tackle that in a separate PR so we're able to do it for all other methods too
Pull Request Checklist
yarn test
)site
folder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:write
)PR-Codex overview
This PR updates the version of multiple packages to
4.18.0-alpha.4
and introduces a new authentication method using JWT in theAlchemySignerWebClient
. It also expands type definitions and enhances session management.Detailed summary
4.17.0
to4.18.0-alpha.4
across multiple packages.submitJwt
method toAlchemySignerWebClient
for JWT authentication.JwtParams
andJwtResponse
types for the new authentication method.Session
type to includecustom-jwt
.SessionManager
.