refactor: remove an unnecessary console.warn #1528
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakecduncan
requested review from
moldy530,
rthomare,
dancoombs,
dphilipson,
linnall,
adamegyed,
howydev,
Zer0dot,
jaypaik,
Blu-J,
jakehobbs,
avarobinson and
florrdv
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd the label graphite-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
🌿 Documentation Preview
|
blakecduncan
commented
Apr 9, 2025
| @@ -88,7 +88,6 @@ export function useSmartAccountClient({ | |||
|
|
|||
| const eoaClient = useMemo(() => { | |||
| if (!isConnected) return null; | |||
| console.warn("EOA is connected, will not return an SCA client"); | |||
There was a problem hiding this comment.
@moldy530 I see you added this in, any concerns with removing this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any dev that implements the eoa connection flow will be flooded with these warnings.
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
This PR focuses on modifying the behavior of the
useSmartAccountClienthook in theaccount-kit/react/src/hooks/useSmartAccountClient.tsfile. It adjusts the logic for returning the smart account client based on the connection status.Detailed summary
console.warn("EOA is connected, will not return an SCA client");nullfor theeoaClientwhenisConnectedis false.clientproperty in the returned object is set toundefined.