feat: adds webauthn session key support#1563
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
How to use the Graphite Merge QueueAdd the label graphite-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
🌿 Documentation Preview
|
linnall
commented
Apr 24, 2025
linnall
commented
Apr 24, 2025
linnall
force-pushed
the
linna/webauth-tests
branch
from
36cd477 to
7549458
Compare
moldy530
reviewed
Jun 19, 2025
account-kit/smart-contracts/src/ma-v2/actions/install-validation/installValidation.ts
Outdated
Show resolved
Hide resolved
moldy530
reviewed
Jun 19, 2025
account-kit/smart-contracts/src/ma-v2/actions/install-validation/installValidation.ts
Outdated
Show resolved
Hide resolved
howydev
reviewed
Jun 19, 2025
account-kit/smart-contracts/src/ma-v2/actions/install-validation/installValidation.ts
Show resolved
Hide resolved
howydev
reviewed
Jun 19, 2025
account-kit/smart-contracts/src/ma-v2/actions/install-validation/installValidation.ts
Outdated
Show resolved
Hide resolved
howydev
previously approved these changes
Jun 19, 2025
Contributor
howydev
left a comment
howydev
left a comment
There was a problem hiding this comment.
some nits otherwise LGTM!
howydev
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
This PR introduces the
NotAModularAccountV2Errorclass and updates various components to support modular account functionalities. It enhances error handling and modifies type definitions for better clarity and usability within the account validation process.Detailed summary
NotAModularAccountV2Errorclass inaa-sdk/core/src/errors/account.ts.aa-sdk/core/src/index.tsto includeNotAModularAccountV2Error.NotAModularAccountV2Errorindocs/pages/reference/aa-sdk/core/classes/NotAModularAccountV2Error/constructor.mdx.examples/ui-demo/src/hooks/useModularAccountV2Client.tsto useModularAccountV2.account-kit/smart-contracts/src/ma-v2/actions/install-validation/installValidation.tsto throwNotAModularAccountV2Errorwhen applicable.isModularAccountV2to check account type inaccount-kit/smart-contracts/src/ma-v2/account/common/modularAccountV2Base.ts.account-kit/smart-contracts/src/ma-v2/client/client.test.tsto cover new validation scenarios involvingWebAuthn.