Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

copi: a new modern high performance go serializer #143

Merged
merged 1 commit into from
Jun 9, 2024
Merged

copi: a new modern high performance go serializer #143

merged 1 commit into from
Jun 9, 2024

Conversation

nazarifard
Copy link
Contributor

goserbench now supported copi.
please merge copi branch with master branch

@alecthomas
Copy link
Owner

Thanks!

@alecthomas alecthomas merged commit 6992cb1 into alecthomas:master Jun 9, 2024
2 checks passed
@nazarifard
Copy link
Contributor Author

Thanks!

Thanks for your code review and approve.
Can I ask you to update to run stats.sh and update README.md tables that includes "Copi" result?

@nazarifard nazarifard deleted the copi branch June 9, 2024 21:36
@alecthomas
Copy link
Owner

You can do this yourself by following the instructions and sending a PR.

@nazarifard
Copy link
Contributor Author

You can do this yourself by following the instructions and sending a PR.

No, I can't. firstly my laptop just has 4 core and I cant run benchmark with 8 cores, secondly I tried to run ./stats.sh several times but it was failed all. Please If its possible run ./stats.sh to update and inclode "copi" serializer's results too.

@nazarifard
Copy link
Contributor Author

You can do this yourself by following the instructions and sending a PR.

No, I can't. firstly my laptop just has 4 core and I cant run benchmark with 8 cores, secondly I tried to run ./stats.sh several times but it was failed all. Please If its possible run ./stats.sh to update and inclode "copi" serializer's results too.

any update?
@alecthomas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecthomas alecthomas alecthomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nazarifard @alecthomas