Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted root package to main package #165

Merged
merged 6 commits into from
Jun 21, 2024
Merged

Converted root package to main package #165

merged 6 commits into from
Jun 21, 2024

Conversation

deneonet
Copy link
Collaborator

Copy link
Contributor

@matheusd matheusd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This currently loses the ability to use the -benchtime flag, which means

1- CI runs will take much longer now (because we can't reduce the bench time target)
2- No way to improve accuracy by increasing the bench time target

I don't think there's a way to internally reach out to modify the benchtime arg (unless there's a very clever way) so I'd suggest still allowing running the benchmarks via go test, at least to improve the CI situation.

benchmark.go Outdated Show resolved Hide resolved
@deneonet
Copy link
Collaborator Author

Should be good now.

.github/workflows/go.yml Outdated Show resolved Hide resolved
@deneonet deneonet merged commit 702bb70 into alecthomas:master Jun 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants