Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a drawer slide animation #59

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

zbarbuto
Copy link
Contributor

Allows customizing the drawer slide in addition to the content slide.

When combined with the scale customization in #58 we can create a more "push" style drawer effect ranging from subtle to a more full push.

Example:

Screen.Recording.2025-01-17.at.2.28.49.PM.mov

@zbarbuto zbarbuto force-pushed the feature/drawer-slide branch from e22f5e1 to 6bfaf5b Compare January 17, 2025 04:04
@alex-melnyk
Copy link
Owner

Please add a new parameter usage description to the readme file.

@zbarbuto zbarbuto force-pushed the feature/drawer-slide branch from 6bfaf5b to 00442c7 Compare January 17, 2025 10:34
@zbarbuto
Copy link
Contributor Author

Done - will probably be conflicts with #58

@alex-melnyk
Copy link
Owner

Done - will probably be conflicts with #58

Yes, please resolve conflicts

alex-melnyk
alex-melnyk previously approved these changes Jan 17, 2025
@zbarbuto
Copy link
Contributor Author

Resolved.

@zbarbuto
Copy link
Contributor Author

Hey @alex-melnyk sorry to ping you but any chance you could take a look at this again?

Also, once merged, would it be possible to release this long with the other recent changes as 1.4.0? I'm happy to PR a changelog and version bump if it's useful.

@alex-melnyk alex-melnyk merged commit 8e6964d into alex-melnyk:master Jan 29, 2025
@alex-melnyk
Copy link
Owner

Hey @alex-melnyk sorry to ping you but any chance you could take a look at this again?

Also, once merged, would it be possible to release this long with the other recent changes as 1.4.0? I'm happy to PR a changelog and version bump if it's useful.

Published with version 1.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants