Skip to content

Commit

Permalink
[BUG] Restore the original default order of CSR, which does not rever…
Browse files Browse the repository at this point in the history
…se edges in cuGraph-PyG (rapidsai#3980)

OGB and many other datasets express the edge index in CSR order, but in release 23.10, the default order was changed to CSC, which broke downstream workflows.  This PR restores the original default, which should be acceptable for the most common datasets, and familiar to most PyG users.

Closes rapidsai#3969

Authors:
  - Alex Barghi (https://github.com/alexbarghi-nv)

Approvers:
  - Tingyu Wang (https://github.com/tingyu66)
  - Rick Ratzel (https://github.com/rlratzel)

URL: rapidsai#3980
  • Loading branch information
alexbarghi-nv authored Nov 7, 2023
1 parent 586451d commit a3cda5d
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions python/cugraph-pyg/cugraph_pyg/data/cugraph_store.py
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ def __init__(
num_nodes_dict: Dict[str, int],
*,
multi_gpu: bool = False,
order: str = "CSC",
order: str = "CSR",
):
"""
Constructs a new CuGraphStore from the provided
Expand Down Expand Up @@ -260,11 +260,11 @@ def __init__(
Whether the store should be backed by a multi-GPU graph.
Requires dask to have been set up.
order: str (Optional ["CSR", "CSC"], default = CSC)
The order to use for sampling. Should nearly always be CSC
unless there is a specific expectation of "reverse" sampling.
It is also not uncommon to use CSR order for correctness
testing, which some cuGraph-PyG tests do.
order: str (Optional ["CSR", "CSC"], default = CSR)
The order to use for sampling. CSR corresponds to the
standard OGB dataset order that is usually used in PyG.
CSC order constructs the same graph as CSR, but with
edges in the opposite direction.
"""

if None in G:
Expand Down

0 comments on commit a3cda5d

Please sign in to comment.