Skip to content

Commit

Permalink
remove unnecessary 'setuptools' and 'wheel' dependencies (rapidsai#4448)
Browse files Browse the repository at this point in the history
Contributes to rapidsai/build-planning#62.

It looks like the `cugraph` and `pylibcugraph` wheels and conda recipes have unnecessary dependencies on `setuptools` and `wheel`. I suspect those are left over from before those libraries were cut over to `scikit-build-core`.

This proposes removing those.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Jake Awe (https://github.com/AyodeAwe)
  - Rick Ratzel (https://github.com/rlratzel)

URL: rapidsai#4448
  • Loading branch information
jameslamb authored May 30, 2024
1 parent 279e66d commit ee4cbb7
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 8 deletions.
1 change: 0 additions & 1 deletion conda/recipes/cugraph/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ requirements:
- raft-dask ={{ minor_version }}
- rmm ={{ minor_version }}
- scikit-build-core >=0.7.0
- setuptools
run:
- aiohttp
- {{ pin_compatible('cuda-version', max_pin='x', min_pin='x') }}
Expand Down
1 change: 0 additions & 1 deletion conda/recipes/pylibcugraph/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ requirements:
- pylibraft ={{ minor_version }}
- python
- scikit-build-core >=0.7.0
- setuptools
run:
- {{ pin_compatible('cuda-version', max_pin='x', min_pin='x') }}
{% if cuda_major == "11" %}
Expand Down
2 changes: 0 additions & 2 deletions dependencies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ files:
table: build-system
includes:
- common_build
- python_build_wheel
- depends_on_rmm
- depends_on_pylibraft
- depends_on_pylibcugraph
Expand Down Expand Up @@ -105,7 +104,6 @@ files:
table: build-system
includes:
- common_build
- python_build_wheel
- depends_on_rmm
- depends_on_pylibraft
- python_build_cythonize
Expand Down
2 changes: 0 additions & 2 deletions python/cugraph/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ requires = [
"pylibraft==24.8.*",
"rmm==24.8.*",
"scikit-build-core[pyproject]>=0.7.0",
"setuptools>=61.0.0",
"wheel",
] # This list was generated by `rapids-dependency-file-generator`. To make changes, edit ../../dependencies.yaml and run `rapids-dependency-file-generator`.
build-backend = "scikit_build_core.build"

Expand Down
2 changes: 0 additions & 2 deletions python/pylibcugraph/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ requires = [
"pylibraft==24.8.*",
"rmm==24.8.*",
"scikit-build-core[pyproject]>=0.7.0",
"setuptools>=61.0.0",
"wheel",
] # This list was generated by `rapids-dependency-file-generator`. To make changes, edit ../../dependencies.yaml and run `rapids-dependency-file-generator`.
build-backend = "scikit_build_core.build"

Expand Down

0 comments on commit ee4cbb7

Please sign in to comment.