Skip to content

Redesign snap page #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Redesign snap page #8

wants to merge 9 commits into from

Conversation

alexdlukens
Copy link
Owner

Snap page now scrolls as one cohesive element

Cue the Copilot summary:

This pull request introduces updates to the store-tui project, including dependency changes, code refactoring for improved type safety and functionality, and styling adjustments for the user interface. Below is a breakdown of the most important changes grouped by theme.

Dependency Updates:

  • Updated snap-python dependency from 0.0.5 to >0.1 for compatibility improvements. Added snakeviz to development dependencies in pyproject.toml.
  • Updated project version to 0.1.6 in pyproject.toml and snapcraft.yaml. [1] [2]

Code Refactoring:

  • Changed categories type in CategoryModal from list[tuple[str, str]] to list[str] for simplicity.
  • Refactored SnapModal class to replace TextArea with Markdown for better text rendering and adjusted get_icon_url method to handle None values for media. Removed unused install_button attribute. [1] [2] [3]
  • Improved type handling in SnapResultTable and SnapStoreTUI classes by adding support for Optional types and default values for empty responses. [1] [2] [3]

UI Styling Adjustments:

  • Updated snap_modal.tcss to remove padding and borders for cleaner visuals, adjusted row heights, and added a bottom border to the summary row. Introduced new styles for Vertical and #description-text elements. [1] [2] [3]

Snapcraft Metadata:

  • Added source-code field to snapcraft.yaml for better project documentation.

These changes collectively enhance the project's maintainability, user interface, and compatibility with dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant