Change xid computation logic #101
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreusel
approved these changes
Dec 13, 2020
rambo-panda
reviewed
Feb 23, 2021
| header.type !== jute.OP_CODES.PING && | ||
| header.type !== jute.OP_CODES.AUTH) { | ||
|
|
||
| this.xid = (this.xid % 2147483647) + 1; |
There was a problem hiding this comment.
I think we just need to set the initial value of XID to 1.
because
a: The role of xid is to ensure the order of requests, so we should not break its meaning.
b: 2 ** 32 -1 I believe this value can meet most needs
There was a problem hiding this comment.
With a continuously running application doing on average 100 requests per second (mine, which is not a huge one, already does way more), that would break after 248.5 days.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zookeeper doesn't handle xid = 0 properly, so change logic to start xid from 1 and properly handle integer overflow
see #100 for detailed explanation