fixed ConnectionManager infinite connect retries #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR build failed, could you fix it first? |
|
Sorry, i fix it first. |
lib/ConnectionManager.js
Outdated
There was a problem hiding this comment.
You need to set the timer in connect rather than in the constructor. If the caller waits before calling connect you would fire too early.
added 2 commits
May 7, 2015 17:59
|
Is this PR going to be merged? |
artofspeed
added a commit
to artofspeed/node-zookeeper-client
that referenced
this pull request
Oct 7, 2018
alexguan#37 PR in original repo
dreusel
added a commit
to dreusel/node-zookeeper-client
that referenced
this pull request
Dec 13, 2020
fix ConnectionManager infinite connect retries alexguan#37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add sessionTimeoutHandler