Skip to content

Conversation

@pbarbarant
Copy link
Collaborator

@pbarbarant pbarbarant commented Sep 19, 2024

Closes #75 and improves testing of both FUGWBarycenter and FUGWSparseBarycenter.

@pbarbarant pbarbarant changed the title Convert coarse plan to np [BUGFIX] Fixes CI + other tests Sep 19, 2024
@bthirion
Copy link
Collaborator

I'll review when the CI is green.

@pbarbarant
Copy link
Collaborator Author

I'll review when the CI is green.

Fixed.

Copy link
Collaborator

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall.

@pbarbarant
Copy link
Collaborator Author

pbarbarant commented Sep 23, 2024

I also added extra assertions on the outputs of FUGW barycenters and tested the callbacks system on the sparse version.

Copy link
Collaborator

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx.

@pbarbarant pbarbarant merged commit dc8b819 into alexisthual:main Sep 23, 2024
7 checks passed
@pbarbarant pbarbarant deleted the fix/fix-barycenter-tests branch September 23, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Fix tests

2 participants