-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add comment on PR #20
Conversation
✔️ Deploy Preview for algolia-ga-actions-netlify ready! 🔨 Explore the source changes: 5a19575 🔍 Inspect the deploy log: https://app.netlify.com/sites/algolia-ga-actions-netlify/deploys/60ed58329830d400089279f1 😎 Browse the preview: https://deploy-preview-20--algolia-ga-actions-netlify.netlify.app |
@@ -54,6 +56,34 @@ function getRecordExtractorSource(): string { | |||
}`; | |||
} | |||
|
|||
function addComment(crawlerId: string): void { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR should have a comment no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, the GA tests are running the version 0.6 which doesn't have the comment feature yet. I'm not sure how to test it efficently
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's try with the next PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌🏻
const prNumber = context.payload.pull_request.number; | ||
|
||
const octokit = github.getOctokit(GITHUB_TOKEN); | ||
octokit.rest.issues.createComment({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that I think about it, would be create to not recreate a comment but find the previous one
can be done in an other PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just having a look at that GA : https://github.com/marketplace/actions/find-comment
# [0.7.0](v0.6.0...v0.7.0) (2021-07-13) ### Features * Add comment on PR ([#20](#20)) ([6ed9d2c](6ed9d2c))
Add comment logic in the action to add a comment on the PR