feat(index): make IndexOptions['uiState'] and UiState react to generic #6288
+23
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haroenv
requested review from
a team,
dhayab and
sarahdayan
and removed request for
a team
Haroenv
commented
Jul 18, 2024
| @@ -266,7 +266,8 @@ export default (function connectGeoSearch< | |||
| return { | |||
| $$type, | |||
|
|
|||
| init(initArgs) { | |||
| // Type is explicitly redefined, to avoid having the TWidgetParams type in the definition | |||
There was a problem hiding this comment.
aymeric-giraudet
previously approved these changes
Jul 19, 2024
Haroenv
dismissed
aymeric-giraudet’s stale review
thanks for the review, but CI still needs to pass, probably a similar issue as in 0cde49e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If you're reading
uiState(initial ui state) inside init of a widget, it should be the generic UiState which includes this widget's ui state as well.Result