fix(infiniteHits): always return valid showPrevious and showMore functions #6644
+65
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1bbdf6b:
|
Haroenv
changed the title
Haroenv
requested review from
a team,
dhayab and
shaejaz
and removed request for
a team
|
you can ignore the netlify failure, it's fixed in the retry but the status didn't update. Seemingly cache related, not to my PR |
shaejaz
approved these changes
Jun 10, 2025
Haroenv
force-pushed
the
fix/no-flash-button
branch
from
6b4f31e to
1bbdf6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We default the infinite hits showPrevious to true, but in the initial render the functions
showPreviousandshowMoreare not yet present in the sate. This fixes that and ensures the functions are always returned.Result