fix(breadcrumb): use hierarchical facets only #6645
Merged
+208
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 50d3bb2:
|
Haroenv
reviewed
Jun 10, 2025
packages/instantsearch.js/src/connectors/breadcrumb/connectBreadcrumb.ts
Outdated
Show resolved
Hide resolved
shaejaz
changed the title
Haroenv
reviewed
Jun 11, 2025
packages/instantsearch.js/src/connectors/breadcrumb/__tests__/connectBreadcrumb-test.ts
Outdated
Show resolved
Hide resolved
packages/instantsearch.js/src/connectors/breadcrumb/__tests__/connectBreadcrumb-test.ts
Show resolved
Hide resolved
…connectBreadcrumb-test.ts
Haroenv
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Breadcrumb connector accesses all facet names when generating the breadcrumb list. This results in a menu widget breaking functionality. This PR restricts the breadcrumb connector to only use attribute from the hierarchical menu to prevent this.
CR-8481
Result
Breadcrumbs now only shows hierarchical facets.
This also initializes an 'interaction' shared test suite which tests functionality of widgets used in tandem (only breadcrumbs + hierarchical menu + menu for now)
Codesandbox: https://codesandbox.io/p/sandbox/example-react-instantsearch-getting-started-l7y5j9